Skip to content

Invalid path for ISAACSCRIPT_COMMON_PATH#127

Merged
Zamiell merged 1 commit intoIsaacScript:mainfrom
elliottcarlson:custom-stage-fix
Jul 24, 2025
Merged

Invalid path for ISAACSCRIPT_COMMON_PATH#127
Zamiell merged 1 commit intoIsaacScript:mainfrom
elliottcarlson:custom-stage-fix

Conversation

@elliottcarlson
Copy link
Contributor

Changes

  • ISAACSCRIPT_COMMON_PATH was including a "src" directory, which would not exist in the distribution of isaacscript-common; this causes Custom Stages to not work at compile time due to a failed isDirectory check:
    if (!isDirectory(ISAACSCRIPT_COMMON_PATH)) {
    const addCommand = getPackageManagerAddCommand(
    packageManager,
    ISAACSCRIPT_COMMON,
    );
    fatalError(
    `The custom stages feature requires a dependency of "${ISAACSCRIPT_COMMON}" in the "package.json" file. You can add it with the following command:\n${chalk.green(
    addCommand,
    )}`,
    );
    }

@Zamiell Zamiell closed this Jul 24, 2025
@Zamiell Zamiell reopened this Jul 24, 2025
@Zamiell Zamiell merged commit 736b3ff into IsaacScript:main Jul 24, 2025
27 checks passed
@Zamiell
Copy link
Member

Zamiell commented Jul 24, 2025

you're right thank you very much!

@Zamiell
Copy link
Member

Zamiell commented Jul 24, 2025

just published isaacscript-cli@5.2.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants